prevent callback skipping with triggerOnce and merged refs#747
Open
djk01281 wants to merge 1 commit intothebuilder:mainfrom
Open
prevent callback skipping with triggerOnce and merged refs#747djk01281 wants to merge 1 commit intothebuilder:mainfrom
djk01281 wants to merge 1 commit intothebuilder:mainfrom
Conversation
|
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
965a07c to
9b4e330
Compare
9b4e330 to
50f709d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! 👋🏻 I ran into this bug while using multiple
useInViewhooks with merged refs, so I opened an issue and put together this fix.Let me know if anything needs to be changed!
Loving the library by the way : )
Description
Fixes #746
This PR fixes a bug where callbacks are skipped when multiple
useInView({ triggerOnce: true })hooks are merged on the same element.Problem
When a callback executes with
triggerOnce: true, it callsunobserve()which removes the callback from the array usingsplice(). This modifies the array duringforEachiteration, causing subsequent callbacks to be skipped.Solution
Copy the callbacks array before iterating using the spread operator:
This prevents the iteration from being affected by array modifications.
Changes
triggerOnceand merged refsTesting
Added a new test that reproduces the bug:
useInViewhooks withtriggerOnce: trueinView: trueBefore fix: Test fails - only hooks 1 and 3 trigger, hook 2 remains
falseAfter fix: Test passes - all 3 hooks trigger correctly : )